[Lldb-commits] [lldb] [NFCI][lldb][test] Avoid unnecessary GNU extension for assembly call (PR #167221)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Raul Tambre (tambry)

<details>
<summary>Changes</summary>

`asm()` on function declarations is used for specifying the mangling. But that specific spelling is a GNU extension unlike `__asm()`.

Found by building with `-std=c2y` in Clang's C frontend's config file.

---
Full diff: https://github.com/llvm/llvm-project/pull/167221.diff


1 Files Affected:

- (modified) lldb/test/Shell/Unwind/Inputs/call-asm.c (+2-2) 


``````````diff
diff --git a/lldb/test/Shell/Unwind/Inputs/call-asm.c b/lldb/test/Shell/Unwind/Inputs/call-asm.c
index b154c1ac1385d..778c16b36a761 100644
--- a/lldb/test/Shell/Unwind/Inputs/call-asm.c
+++ b/lldb/test/Shell/Unwind/Inputs/call-asm.c
@@ -1,3 +1,3 @@
-int asm_main() asm("asm_main");
-
+// Explicit mangling is necessary as on Darwin an underscore is prepended to the symbol.
+int asm_main() __asm("asm_main");
 int main() { return asm_main(); }

``````````

</details>


https://github.com/llvm/llvm-project/pull/167221