[Lldb-commits] [lldb] Add a `breakpoint add` command to fix the option-madness that is `breakpoint set` (PR #156067)

[via lldb-commits]

jimingham wrote:

> LGTM, there's really not that much actual new code to review. The code duplication is unfortunate but I don't think that should stand in the way of a more ergonomic command. Could we add a big warning at the top of the old and new file to remind folks to at least try to keep the two in sync for now?

I would say "no more changes allowed to `break set` except mutatis mutandis for API changes.  I don't want to add new features in parallel for the two because that would severely limit the improvements we could make to `break add` - one of the big reasons for moving over to `break add` is that we can make improvements that were impossible with the older structure.  And if we're fixing bugs, they are for the most part going to be in code either one of these commands calls, not in the command parsing and dispatch.

So for the most part I'd like to declare `break set` frozen except for bugs, and have all future work and improvements done to `break add`.

> 
> I left some comments for improvements, though I realize this is all pre-existing code. We would be better off addressing it for both the old and new implementation in a follow up PR.



https://github.com/llvm/llvm-project/pull/156067