[Lldb-commits] [lldb] Add a `breakpoint add` command to fix the option-madness that is `breakpoint set` (PR #156067)
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Fri Nov 7 12:02:19 PST 2025
https://github.com/JDevlieghere approved this pull request.
LGTM, there's really not that much actual new code to review. The code duplication is unfortunate but I don't think that should stand in the way of a more ergonomic command. Could we add a big warning at the top of the old and new file to remind folks to at least try to keep the two in sync for now?
I left some comments for improvements, though I realize this is all pre-existing code. We would be better off addressing it for both the old and new implementation in a follow up PR.
https://github.com/llvm/llvm-project/pull/156067
More information about the lldb-commits
mailing list