[Lldb-commits] [lldb] [lldb] Support arbitrary precision integer registers (PR #166363)

[David Spickett via lldb-commits]

Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <m4tej.kosik at gmail.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/166363 at github.com>


https://github.com/DavidSpickett commented:

Good idea to do BE/LE for all tests.

More bikeshedding to do on the name, and there are some methods in `lldb/include/lldb/Utility/RegisterValue.h` that deal with UInt128.

Certainly the GetValueAsUInt128 method should fail if the length is > 128, as there are existing callers of that. Same for getting as 32-bit if its 33 and so on.

For setting, hard to say without a use case but I presume you have one. Have you been using this for targets and had to set registers of these sizes? Could be that internally they are constructed mostly from memory buffers so this isn't an issue.



https://github.com/llvm/llvm-project/pull/166363