[Lldb-commits] [lldb] [lldb] Make it so not finding and SDK doesn't look like an error (PR #166676)
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Wed Nov 5 16:52:44 PST 2025
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/166676
There may be valid reasons for not being able to find an SDK. Right now, it's printed as an error, which is causing confusion for users that interpret the error as something fatal, and not something that can be ignored.
rdar://155346799
>From 9c5d8044bb083fe8ffb58aeb339a7a7915eeefc3 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere <jonas at devlieghere.com>
Date: Wed, 5 Nov 2025 16:51:01 -0800
Subject: [PATCH] [lldb] Make it so not finding and SDK doesn't look like an
error
There may be valid reasons for not being able to find an SDK. Right now,
it's printed as an error, which is causing confusion for users that
interpret the error as something fatal, and not something that can be
ignored.
rdar://155346799
---
lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp | 2 +-
.../Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp b/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
index 4cfb0a81dc6e4..887748b9e9c85 100644
--- a/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
+++ b/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
@@ -90,7 +90,7 @@ void PlatformAppleSimulator::GetStatus(Stream &strm) {
if (!sdk.empty())
strm << " SDK Path: \"" << sdk << "\"\n";
else
- strm << " SDK Path: error: unable to locate SDK\n";
+ strm << " SDK Path: <unable to locate SDK>\n";
#if defined(__APPLE__)
// This will get called by subclasses, so just output status on the current
diff --git a/lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp b/lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp
index b83d07b19235c..7b524d27b5221 100644
--- a/lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp
+++ b/lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp
@@ -53,7 +53,7 @@ void PlatformRemoteDarwinDevice::GetStatus(Stream &strm) {
if (sdk_directory)
strm.Printf(" SDK Path: \"%s\"\n", sdk_directory);
else
- strm.PutCString(" SDK Path: error: unable to locate SDK\n");
+ strm.PutCString(" SDK Path: <unable to locate SDK>\n");
const uint32_t num_sdk_infos = m_sdk_directory_infos.size();
for (uint32_t i = 0; i < num_sdk_infos; ++i) {
More information about the lldb-commits
mailing list