[Lldb-commits] [lldb] [lldb] Support arbitrary precision integer registers (PR #166363)

[Jonas Devlieghere via lldb-commits]

Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>,
Matej =?utf-8?q?Košík?= <matej.kosik at codasip.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/166363 at github.com>


================
@@ -218,7 +218,7 @@ class RegisterValue {
   }
 
   void SetUInt128(llvm::APInt uint) {
-    m_type = eTypeUInt128;
+    m_type = eTypeUIntBig;
     m_scalar = std::move(uint);
   }
----------------
JDevlieghere wrote:

I'm worried that `eTypeUInt` sounds slightly too generic. Why would I pick `eTypeUInt64` if I can just pick `eTypeUInt`? I was hoping that the `AP` suffix would help clarify what it's supposed to be used for, similar to what "Big" did in your original patch. WDYT?

https://github.com/llvm/llvm-project/pull/166363