[Lldb-commits] [lldb] [lldb][Runtime] Move VerboseTrapFrameRecognizer into CPPLanguageRuntime (PR #166157)

[Dan Liew via lldb-commits]

delcypher wrote:

> An alternative discussed was to create a common CLanguageRuntime whose currentl sole responsibility was to register the VerboseTrapFrameRecognizer and AssertStackFrameRecognizer. However, making this plugin a fully-fledged runtime felt wrong because all the LanguageRuntime functionality would live in the derived C++/ObjC runtime plugins.

I don't quite follow this. Presumably you'd have

```
class CLanguageRuntime : public LanguageRuntime {
   // ...
```

What about that design implies you'd have to put the recognizer inside `CPPLanguageRuntime`? Surely it would go in `CLanguageRuntime`? Or do you mean you'd have to add the recognizer to other runtimes too because `__builtin_verbose_trap` is actually supported by C/C++/objective-C/objective-c++ ?

https://github.com/llvm/llvm-project/pull/166157