[Lldb-commits] [clang] [lldb] [Clang][LLDB] Refactor trap reason demangling out of LLDB and into Clang (PR #165996)

[Dan Liew via lldb-commits]

================
@@ -97,6 +97,9 @@ add_lldb_library(lldbTarget
     lldbUtility
     lldbValueObject
     lldbPluginProcessUtility
+
+  CLANG_LIBS
+    clangCodeGen
----------------
delcypher wrote:

>  Only LLDB's Clang plugin (and dependent components) should link libClang

Can you elaborate on this restriction? Given that LLDB already links against Clang it's not obvious to me why linking against `clangCodeGen` would be a problem. The linker and loader on macOS didn't seem to complain when I made this change so this doesn't seem like a fundamental restriction so maybe this is a preferred architectural design?

> We wanted to move all the frame recognizers to a common C language plugin (which doesnt exist yet). Maybe now is the time to do so. I started doing that a while back. I can try to revive that

Rather than move all the frame recognizers at once maybe we could just move the `VerboseTrapFrameRecognizer.cpp` into a new library and then separately the others can be moved over incrementally? I'm suggesting this because I'd prefer to make this change as simple as possible as this patch is just a stepping stone to the instrumentation plug-in that I'm implementing.

https://github.com/llvm/llvm-project/pull/165996