[Lldb-commits] [lldb] [lldb][NFC] Refactor Watchpoint class (PR #163695)

[David Spickett via lldb-commits]

================
@@ -26,45 +27,105 @@
 using namespace lldb;
 using namespace lldb_private;
 
-Watchpoint::Watchpoint(Target &target, lldb::addr_t addr, uint32_t size,
-                       const CompilerType *type, bool hardware)
-    : StoppointSite(0, addr, size, hardware), m_target(target),
-      m_enabled(false), m_is_hardware(hardware), m_is_watch_variable(false),
-      m_is_ephemeral(false), m_disabled_count(0), m_watch_read(0),
-      m_watch_write(0), m_watch_modify(0), m_ignore_count(0) {
+static bool IsValueObjectsEqual(lldb::ValueObjectSP lhs,
----------------
DavidSpickett wrote:

If the function name were a sentence it would be "Are Value Objects Equal?". So either AreValueObjectsEqual or ValueObjectsAreEqual.

I wonder if this could be sunk into ValueObject, assuming it only needs things from the ValueObjects themselves.

https://github.com/llvm/llvm-project/pull/163695