[Lldb-commits] [lldb] [LLDB] Skip TestMultipleSlides.py on Windows (PR #165604)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: nerix (Nerixyz)

<details>
<summary>Changes</summary>

After the default PDB plugin changed to the native one (#<!-- -->165363), this test failed, because it uses the size of public symbols and the native plugin sets the size to 0 (as PDB doesn't include this information explicitly). DWARF emitted by clang on Windows doesn't include the public symbols, so LLDB fell back to PDB.

---
Full diff: https://github.com/llvm/llvm-project/pull/165604.diff


1 Files Affected:

- (modified) lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py (+3) 


``````````diff
diff --git a/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py b/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py
index 3d6b27fe68a1b..48db92b611cfa 100644
--- a/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py
+++ b/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py
@@ -12,6 +12,9 @@
 class MultipleSlidesTestCase(TestBase):
     NO_DEBUG_INFO_TESTCASE = True
 
+    # DWARF doesn't include public symbols on Windows, so LLDB falls back to the PDB.
+    # Symbols don't have a size in the native PDB plugin.
+    @skipIfWindows
     def test_mulitple_slides(self):
         """Test that a binary can be slid multiple times correctly."""
         self.build()

``````````

</details>


https://github.com/llvm/llvm-project/pull/165604