[Lldb-commits] [lldb] [llvm] [LLDB] Use native PDB reader by default (PR #165363)

[David Spickett via lldb-commits]

DavidSpickett wrote:

> The setting is not in any release yet. Before, you had to use the environment variable.

I did not realise the setting hasn't been around that long. It was added in https://github.com/llvm/llvm-project/pull/151490:

> This would make it possible to test both native PDB and DIA PDB in the API tests (see linked PR).

So for as long as we do / might need to do this, the setting remains. Even if we don't mention it in release notes, it is something users can discover. I was wondering if we should remove it so we didn't have one more thing to keep around for another release cycle.

I think not though. If all goes to plan:
* Native becomes the default in the next release.
* DIA is removed the release after, and the setting only accepts native.
* Release after that, if we remember, we can remove the setting. If we forget it's not a big deal, since it's basically read only at that point.

You can merge this whenever you're ready.

https://github.com/llvm/llvm-project/pull/165363