[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Don't silently inherit the VFS from `FileManager` (PR #164323)

Qiongsi Wu via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 22 08:54:27 PDT 2025


https://github.com/qiongsiwu approved this pull request.

Thanks! LGTM. 

There are two places where we reset file manager but do not reset the VFS. Could you help me confirm that these are OK? I think they are because these are already in frontend actions  and I assume we intend to preserve the VFS (but need to set the file manager to something else). 

https://github.com/llvm/llvm-project/blob/6fca1381189065bf363257d5bc626f4f11e91a7f/clang/lib/Frontend/FrontendAction.cpp#L1391

https://github.com/llvm/llvm-project/blob/6fca1381189065bf363257d5bc626f4f11e91a7f/clang/lib/Frontend/Rewrite/FrontendActions.cpp#L143

https://github.com/llvm/llvm-project/pull/164323


More information about the lldb-commits mailing list