[Lldb-commits] [lldb] [lldb] Added a warning in case of instruction decode failure (PR #164413)

[David Spickett via lldb-commits]

================
@@ -0,0 +1,32 @@
+"""
+Test the 'memory read' command when decoding instruction failures.
+"""
----------------
DavidSpickett wrote:

Got the expected error with:
```
diff --git a/lldb/test/API/riscv/decode-failure/TestDecodeFailure.py b/lldb/test/API/riscv/decode-failure/TestDecodeFailure.py
index 88f72a7cbb6c..c940aadd36f5 100644
--- a/lldb/test/API/riscv/decode-failure/TestDecodeFailure.py
+++ b/lldb/test/API/riscv/decode-failure/TestDecodeFailure.py
@@ -18,7 +18,7 @@ class MemoryReadTestCase(TestBase):
             self, "// break here", lldb.SBFileSpec("main.c")
         )
 
-    @skipIf(archs=no_match("^riscv.*"))
+    @skipIf(archs=no_match("^(riscv|aarch64).*"))
     def test_memory_read(self):
         """Test the 'memory read' command with instruction format."""
         self.build_run_stop()
@@ -27,6 +27,6 @@ class MemoryReadTestCase(TestBase):
         # (lldb) memory read --format instruction `&my_insns[0]`
         # expected message: failed to decode instructions at 0x
         self.expect(
-            "memory read --format instruction --count 1 `&my_insns[0]`",
+            "memory read --format instruction `&my_insns[0]` `&my_insns[3]`",
             substrs=["failed to decode instructions at"],
         )
```
If that still fails on riscv then that's good, we only need one "encoding".

https://github.com/llvm/llvm-project/pull/164413