[Lldb-commits] [lldb] 0d20f3f - [lldb][test] Fix address type in ReadMemoryRanges test

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 22 03:21:54 PDT 2025


Author: David Spickett
Date: 2025-10-22T10:21:36Z
New Revision: 0d20f3fa1fee43bc50883fbc988171cc0eb5a8e3

URL: https://github.com/llvm/llvm-project/commit/0d20f3fa1fee43bc50883fbc988171cc0eb5a8e3
DIFF: https://github.com/llvm/llvm-project/commit/0d20f3fa1fee43bc50883fbc988171cc0eb5a8e3.diff

LOG: [lldb][test] Fix address type in ReadMemoryRanges test

Tests added by #163651.

Use lldb::addr_t (which is always 64-bit) for all addresses
so that we don't calculate an invalid address on 32-bit
and segfault.

As happened on Linaro's Arm 32-bit buildbot.

Added: 
    

Modified: 
    lldb/unittests/Target/MemoryTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Target/MemoryTest.cpp b/lldb/unittests/Target/MemoryTest.cpp
index f7b4e97b1f64a..e444f68dc4871 100644
--- a/lldb/unittests/Target/MemoryTest.cpp
+++ b/lldb/unittests/Target/MemoryTest.cpp
@@ -245,7 +245,7 @@ class DummyReaderProcess : public Process {
     if (read_more_than_requested)
       size *= 2;
     uint8_t *buffer = static_cast<uint8_t *>(buf);
-    for (size_t addr = vm_addr; addr < vm_addr + size; addr++)
+    for (lldb::addr_t addr = vm_addr; addr < vm_addr + size; addr++)
       buffer[addr - vm_addr] = static_cast<uint8_t>(addr); // LSB of addr.
     return size;
   }


        


More information about the lldb-commits mailing list