[Lldb-commits] [lldb] [lldb] Show signal number description (PR #164176)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett commented:

This is a good idea, one less reason to leave the debugger.

Took me a while to figure out exactly why you couldn't use the existing method, but that's not because you didn't say so, it's because we have too much overlapping terminology in the existing code.

It's like `GetSignalDescription` is the `__repr__` of the signal, and so should try as hard as it can to return something, sometimes just the name. You specifically want the description part of the information instead.

It's not for this PR but it feels like `GetSignalDescription` should be `GetSignalAsString` or `FormatSignal` or whatever, and `GetSignalAsStringRef` should be `GetSignalName` to match your new method.

Too many things say "signal" when they mean just the signal number but also other things say signal when they mean the whole signal struct.

If you want to have a go at improving that, please do.

Your new method does what it says though so it's ok. If you do change the other names, it could be "GetSignalDescription" as you'd have liked it to be.

https://github.com/llvm/llvm-project/pull/164176