[Lldb-commits] [lldb] [lldb] Show signal number description (PR #164176)

[David Spickett via lldb-commits]

================
@@ -1603,8 +1603,8 @@ class CommandObjectProcessHandle : public CommandObjectParsed {
   Options *GetOptions() override { return &m_options; }
 
   void PrintSignalHeader(Stream &str) {
-    str.Printf("NAME         PASS   STOP   NOTIFY\n");
-    str.Printf("===========  =====  =====  ======\n");
+    str.Printf("NAME         PASS   STOP   NOTIFY  DESCRIPTION\n");
+    str.Printf("===========  =====  =====  ======  ===================\n");
----------------
DavidSpickett wrote:

Also we don't have any tests for this part of the command. There is lldb/test/API/commands/process/handle/TestProcessHandle.py but it's only changing the settings.

Not all platforms will have all signals but we don't want to check them all anyway. The test uses SIGSEGV already. So maybe you can just add :
* one call prior to loading the test binary, that just gets the header
* one later that expects the header and some line for SIGSEGV

The description will change between platforms (though they all mean the same thing), so it would be ok to regex match that there is some string after the last bool.

We don't need to check for the exact string because we trust that the unittests prove that the right description will be used.

https://github.com/llvm/llvm-project/pull/164176