[Lldb-commits] [lldb] [lldb] Add bidirectional packetLog to gdbclientutils.py (PR #162176)

[Daniel Sanders via lldb-commits]

dsandersllvm wrote:

Updated to be a single packetLog in MockGDBServerResponder containing both sent and received packets and the tests have been updated so that they still only check the received packets.

Along the way I noticed that the RESPONSE_DISCONNECT and RESPONSE_NONE classes were being returned by responses. It's not technically wrong in python but mixing instances and classes in a list is a bit odd and it was making type hints tricky to write so these are now instances similar to how None is an instance.

> I miss this feature too. We mention a couple of tools on https://llvm.org/docs/GitHub.html#using-graphite-for-stacked-pull-requests but I've not tried any of them myself.

Thanks, I'll give that a try for the next one

https://github.com/llvm/llvm-project/pull/162176