[Lldb-commits] [lldb] [lldb-dap] Allow empty memory reference in disassemble arguments (PR #162517)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 14 14:50:01 PDT 2025


================
@@ -156,11 +156,15 @@ DecodeMemoryReference(llvm::StringRef memoryReference);
 ///    Indicates if the key is required to be present, otherwise report an error
 ///    if the key is missing.
 ///
+/// \param[in] allow_empty
+///    Interpret empty string as a valid value, don't report an error (see
+///    VSCode issue https://github.com/microsoft/vscode/issues/270593).
----------------
JDevlieghere wrote:

Nit: It's `VS Code` not `VSCode` (https://code.visualstudio.com/brand#brand-name)

https://github.com/llvm/llvm-project/pull/162517


More information about the lldb-commits mailing list