[Lldb-commits] [lldb] [LLDB, FreeBSD, x86] Fix empty register set when trying to get size of register (PR #162890)

[via lldb-commits]

aokblast wrote:

> This is certainly some improvement. Register information handling is weird at the best of times, and going any further refactoring this would obscure the bug that you're fixing.

Emm, I see Linux one also use a more wired method. They take the reference from singloton function and call it g_register_info like std::vector<T> &g_register_info = singloton(). We need to change the RegisterInfo_x86_64.h to fix it.

> 
> I'm ok accepting this without the test for now given that it only affects 32-bit FreeBSD debug, which is already broken anyway.

Thanks for your help!
> 
> When we deal with the test case we'll make sure something reads a few registers to verify this.



> 
> LGTM.
> 
> Please update the PR description to reflect the current changes before landing.

Done.



https://github.com/llvm/llvm-project/pull/162890