[Lldb-commits] [lldb] b0b4a8e - [lldb][test] Fix language note tests on Windows (#162995)

via lldb-commits lldb-commits at lists.llvm.org
Sat Oct 11 05:15:08 PDT 2025


Author: Michael Buch
Date: 2025-10-11T12:15:04Z
New Revision: b0b4a8e9e343306e8070e31cb4839ce4af2ad7c8

URL: https://github.com/llvm/llvm-project/commit/b0b4a8e9e343306e8070e31cb4839ce4af2ad7c8
DIFF: https://github.com/llvm/llvm-project/commit/b0b4a8e9e343306e8070e31cb4839ce4af2ad7c8.diff

LOG: [lldb][test] Fix language note tests on Windows (#162995)

The LLDB test-suite compiles the tests on Windows with 'C++14' by
default:

https://github.com/llvm/llvm-project/blob/3bfb5b0e7ccbcb9f127f5b9c958e6499ba9c0523/lldb/packages/Python/lldbsuite/test/make/Makefile.rules#L357-L360

This fixes Windows buildbot failures.

Added: 
    

Modified: 
    lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
    lldb/test/Shell/Expr/TestExprLanguageNote.test

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py b/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
index ec208f2c32503..759b620105c4e 100644
--- a/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
+++ b/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
@@ -218,11 +218,9 @@ def check_error(diags):
             # Detail 1/3: note: requested expression language
             diag = details.GetItemAtIndex(0)
             self.assertEqual(str(diag.GetValueForKey("severity")), "note")
-            self.assertEqual(
-                str(diag.GetValueForKey("message")), "Ran expression as 'C++11'."
-            )
-            self.assertEqual(
-                str(diag.GetValueForKey("rendered")), "Ran expression as 'C++11'."
+            self.assertIn("Ran expression as 'C++", str(diag.GetValueForKey("message")))
+            self.assertIn(
+                "Ran expression as 'C++", str(diag.GetValueForKey("rendered"))
             )
             self.assertEqual(str(diag.GetValueForKey("source_location")), "")
             self.assertEqual(str(diag.GetValueForKey("file")), "")

diff  --git a/lldb/test/Shell/Expr/TestExprLanguageNote.test b/lldb/test/Shell/Expr/TestExprLanguageNote.test
index f3dc5928fcca9..b4387bf9121ae 100644
--- a/lldb/test/Shell/Expr/TestExprLanguageNote.test
+++ b/lldb/test/Shell/Expr/TestExprLanguageNote.test
@@ -26,7 +26,7 @@ run
 expr blah
 
 # CHECK-TARGET: (lldb) expr
-# CHECK-TARGET: note: Ran expression as 'C++14'.
+# CHECK-TARGET: note: Ran expression as 'C++{{.*}}'
 
 expr -l objc -- blah
 


        


More information about the lldb-commits mailing list