[Lldb-commits] [lldb] [lldb][windows] add support for out of PATH python.dll resolution (PR #162509)

[Charles Zablit via lldb-commits]

================
@@ -167,6 +167,12 @@ function(add_lldb_executable name)
   )
 
   target_link_libraries(${name} PRIVATE ${ARG_LINK_LIBS})
+  if(WIN32)
+    list(FIND ARG_LINK_LIBS liblldb LIBLLDB_INDEX)
+    if(NOT LIBLLDB_INDEX EQUAL -1)
+      target_link_options(${name} PRIVATE "/DELAYLOAD:$<TARGET_FILE_BASE_NAME:liblldb>.dll")
----------------
charles-zablit wrote:

This used to be gated behind a `if(MSVC)` check in the downstream patch: https://github.com/swiftlang/llvm-project/commit/af218c344d1bbf876d165bfbbf902f637080936a. I think that with https://github.com/llvm/llvm-project/pull/162831 we will get a complete solution as if `LLDB_PYTHON_DLL_RELATIVE_PATH` is not set, the mechanism to add to the DLL search path will not even be compiled. If it's set, then it will only work for MSVC and mingw and there will be a warning if it's a different compiler.

> which should give the right string in both cases?

I agree, this is much better 👍 

https://github.com/llvm/llvm-project/pull/162509