[Lldb-commits] [lldb] [lldb][windows] add support for out of PATH python.dll resolution (PR #162509)

[Martin Storsjö via lldb-commits]

================
@@ -167,6 +167,12 @@ function(add_lldb_executable name)
   )
 
   target_link_libraries(${name} PRIVATE ${ARG_LINK_LIBS})
+  if(WIN32)
+    list(FIND ARG_LINK_LIBS liblldb LIBLLDB_INDEX)
+    if(NOT LIBLLDB_INDEX EQUAL -1)
+      target_link_options(${name} PRIVATE "/DELAYLOAD:$<TARGET_FILE_BASE_NAME:liblldb>.dll")
----------------
mstorsjo wrote:

Any particular reason for using `$<TARGET_FILE_BASE_NAME:liblldb>.dll` rather than the more straightforward `$<TARGET_FILE_NAME:liblldb>`?

This patch broke compilation for mingw targets, as these options are specific to the MSVC style build case - and for that case, the DLL name we'd like to pass here has a `lib` prefix, i.e. `liblldb.dll`, not `lldb.dll`. So instead of trying to manually reapply a prefix and add `.dll` at the end, it seems more straightforward to me to just use `$<TARGET_FILE_NAME:liblldb>` which should give the right string in both cases?

https://github.com/llvm/llvm-project/pull/162509