[Lldb-commits] [lldb] [lldb] Add type hints to gdbclientutils.py and use abstract base class (PR #162172)

[David Spickett via lldb-commits]

DavidSpickett wrote:

> That shouldn't be the case. I believe for Swift we have at least one bot that still uses 3.8. If we want to bump the minimum version we should do that through an RFC like David did: https://discourse.llvm.org/t/rfc-lets-document-and-enforce-a-minimum-python-version-for-lldb/82731/20

At this point it would be an update for LLVM generally, which we are due but I don't expect this PR author to take on.

> It's mainly type hints using the subscript operator on the builtin types like list[str]. In 3.8 the correct way is:

If this way will work in 3.9 as well, do it. If not, drop those annotations. Let's not make this situation more confusing, the pay off isn't there for the sake of a few type annotations.

And yes we should have something somewhere enforcing our minimums but let me put it this way: we claim minimum compiler versions and those aren't tested by anyone either. So I'm sorry you had to encounter this confusion but it is what it is for the time being.

https://github.com/llvm/llvm-project/pull/162172