[Lldb-commits] [lldb] [lldb][test] Remove class level packetLog in MockGDBServerResponder (PR #162453)
via lldb-commits
lldb-commits at lists.llvm.org
Wed Oct 8 04:04:01 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
<details>
<summary>Changes</summary>
Added in 1902ffd9a4914d4cd03e200ca9050bf3b1564c19 but appears to be leftover code from some older design.
I can't find any code that reads packetLog via the class itself, or checks whether it is None.
No tests failed on AArch64 Linux after removing it.
---
Full diff: https://github.com/llvm/llvm-project/pull/162453.diff
1 Files Affected:
- (modified) lldb/packages/Python/lldbsuite/test/gdbclientutils.py (-1)
``````````diff
diff --git a/lldb/packages/Python/lldbsuite/test/gdbclientutils.py b/lldb/packages/Python/lldbsuite/test/gdbclientutils.py
index b603c35c8df09..53e991a1471fd 100644
--- a/lldb/packages/Python/lldbsuite/test/gdbclientutils.py
+++ b/lldb/packages/Python/lldbsuite/test/gdbclientutils.py
@@ -87,7 +87,6 @@ class MockGDBServerResponder:
"""
registerCount = 40
- packetLog = None
class RESPONSE_DISCONNECT:
pass
``````````
</details>
https://github.com/llvm/llvm-project/pull/162453
More information about the lldb-commits
mailing list