[Lldb-commits] [lldb] [lldb][test] Remove class level packetLog in MockGDBServerResponder (PR #162453)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 8 04:03:28 PDT 2025


https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/162453

Added in 1902ffd9a4914d4cd03e200ca9050bf3b1564c19 but appears to be leftover code from some older design.

I can't find any code that reads packetLog via the class itself, or checks whether it is None.

No tests failed on AArch64 Linux after removing it.

>From 3d9791d7ffa5a172e86971abf93bd8d48527f5f0 Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at linaro.org>
Date: Wed, 8 Oct 2025 11:01:47 +0000
Subject: [PATCH] [lldb][test] Remove class level packetLog in
 MockGDBServerResponder

Added in 1902ffd9a4914d4cd03e200ca9050bf3b1564c19 but appears
to be leftover code from some older design.

I can't find any code that reads packetLog via the class itself,
or checks whether it is None.

No tests failed on AArch64 Linux after removing it.
---
 lldb/packages/Python/lldbsuite/test/gdbclientutils.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lldb/packages/Python/lldbsuite/test/gdbclientutils.py b/lldb/packages/Python/lldbsuite/test/gdbclientutils.py
index b603c35c8df09..53e991a1471fd 100644
--- a/lldb/packages/Python/lldbsuite/test/gdbclientutils.py
+++ b/lldb/packages/Python/lldbsuite/test/gdbclientutils.py
@@ -87,7 +87,6 @@ class MockGDBServerResponder:
     """
 
     registerCount = 40
-    packetLog = None
 
     class RESPONSE_DISCONNECT:
         pass



More information about the lldb-commits mailing list