[Lldb-commits] [lldb] [lldb] Add bidirectional packetLog to gdbclientutils.py (PR #162176)

[David Spickett via lldb-commits]

DavidSpickett wrote:

> The existing response-only one in MockGDBServerResponder is used by tests so I chose not to change it

Ok so you could have added the sent packets to this but chose not to. That's why it looks a bit strange to me.

How does MockGDBServerResponder use the existing log and why did that push you to making a new one? I guess it's just blindly indexing it, making assumptions about ordering? (because it knows they're all one direction) Seems like we could fix that but idk how much work it would be.

https://github.com/llvm/llvm-project/pull/162176