[Lldb-commits] [lldb] [lldb][test] Set configuration.cmake_build_type only if args.cmake_build_type is not None (PR #162153)

[David Spickett via lldb-commits]

DavidSpickett wrote:

In what situation would this be None or empty? LLVM requires that you set CMAKE_BUILD_TYPE to something and even so, it would have a default value. Are you running tests against a pre-built lldb?

> if args.cmake_build_type is not None

Being pedantic: being None and being falsey are 2 different things in Python. Here you mean if it's empty.

In this case it's not a big deal but it was surprising to see "is not None" in the title and then no "None" mentioned in the change.

https://github.com/llvm/llvm-project/pull/162153