[Lldb-commits] [lldb] [lldb][test] check if CoreDumping is supported at runtime (PR #161385)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 3 16:04:49 PDT 2025


Michael137 wrote:

This is PR CI:
```
2025-10-03T10:01:50.6109918Z /home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googletest/include/gtest/gtest-assertion-result.h:161:9: error: no viable conversion from 'const llvm::VersionTuple' to 'bool'
2025-10-03T10:01:50.6111607Z   161 |       : success_(success) {}
2025-10-03T10:01:50.6112080Z       |         ^        ~~~~~~~
2025-10-03T10:01:50.6113979Z /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Host/posix/HostTest.cpp:120:3: note: in instantiation of function template specialization 'testing::AssertionResult::AssertionResult<llvm::VersionTuple>' requested here
2025-10-03T10:01:50.6115969Z   120 |   ASSERT_TRUE(host_version);
2025-10-03T10:01:50.6116436Z       |   ^
2025-10-03T10:01:50.6117663Z /home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:1815:32: note: expanded from macro 'ASSERT_TRUE'
2025-10-03T10:01:50.6119124Z  1815 | #define ASSERT_TRUE(condition) GTEST_ASSERT_TRUE(condition)
2025-10-03T10:01:50.6120506Z       |                                ^
2025-10-03T10:01:50.6121900Z /home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:1798:3: note: expanded from macro 'GTEST_ASSERT_TRUE'
2025-10-03T10:01:50.6123500Z  1798 |   GTEST_TEST_BOOLEAN_(condition, #condition, false, true, GTEST_FATAL_FAILURE_)
2025-10-03T10:01:50.6124196Z       |   ^
2025-10-03T10:01:50.6125550Z /home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googletest/include/gtest/internal/gtest-internal.h:1493:11: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
2025-10-03T10:01:50.6127425Z  1493 |           ::testing::AssertionResult(expression))                     \
2025-10-03T10:01:50.6128041Z       |           ^
2025-10-03T10:01:50.6128400Z 1 error generated.
```

Looks like we just need to change:
```
ASSERT_TRUE(host_version);
```
to
```
ASSERT_FALSE(host_version.empty());
```

https://github.com/llvm/llvm-project/pull/161385


More information about the lldb-commits mailing list