[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] NFCI: Clean up `CompilerInstance::create{File, Source}Manager()` (PR #160748)

[Michael Kruse via lldb-commits]

Meinersbur wrote:

> > There is an additional reference to this function in polly
> > https://github.com/llvm/llvm-project/blob/d48bda5421c5af9baa5bc98ba4e3a453937ff96a/polly/lib/External/isl/interface/extract_interface.cc#L550
> 
> I'm not sure what to do with these TBH. That file seems to be trying to be compatible with multiple Clang versions, using `#ifdef`s to call the right APIs in each version. I guess I'll CC @Meinersbur for the guidance here.

 The file comes from upstream ISL, and is not used when compiling LLVM. Its purpose is to read the C header files of ISL, and emit C++ wrapper classes+methods for these. Upstream ISL needs to work with the version of Clang the users has installed, hence the ifdefs. You can safely ignore this file, it will be updated by the maintainer of ISL who will eventually add a new #ifdef for this change to to work with the next release of Clang. 

https://github.com/llvm/llvm-project/pull/160748