[Lldb-commits] [lldb] [lldb][test] check if CoreDumping is supported at runtime (PR #161385)

[Michael Buch via lldb-commits]

================
@@ -120,12 +116,14 @@ TEST_F(HostTest, GetProcessInfoSetsPriority) {
   ASSERT_TRUE(Info.IsZombie().has_value());
   ASSERT_FALSE(Info.IsZombie().value());
 
-  // CoreDumping was added in kernel version 4.15.
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 15, 0)
-  ASSERT_TRUE(Info.IsCoreDumping().has_value());
-  ASSERT_FALSE(Info.IsCoreDumping().value());
-#else
-  ASSERT_FALSE(Info.IsCoreDumping().has_value());
-#endif
+  const llvm::VersionTuple host_version = HostInfo::GetOSVersion();
+  if (!host_version.empty()) {
+    if (host_version >= llvm::VersionTuple(4, 15, 0)) {
+      ASSERT_TRUE(Info.IsCoreDumping().has_value());
+      ASSERT_FALSE(Info.IsCoreDumping().value());
+    } else {
+      ASSERT_FALSE(Info.IsCoreDumping().has_value());
+    }
+  }
----------------
Michael137 wrote:

```suggestion
  const llvm::VersionTuple host_version = HostInfo::GetOSVersion();
  ASSERT_TRUE(host_version);
  if (host_version >= llvm::VersionTuple(4, 15, 0)) {
    ASSERT_TRUE(Info.IsCoreDumping().has_value());
    ASSERT_FALSE(Info.IsCoreDumping().value());
  } else {
    ASSERT_FALSE(Info.IsCoreDumping().has_value());
  }
```


https://github.com/llvm/llvm-project/pull/161385