[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] NFCI: Clean up `CompilerInstance::create{File, Source}Manager()` (PR #160748)

[Ben Langmuir via lldb-commits]

================
@@ -382,17 +382,18 @@ IntrusiveRefCntPtr<DiagnosticsEngine> CompilerInstance::createDiagnostics(
 
 // File Manager
 
-FileManager *CompilerInstance::createFileManager() {
+void CompilerInstance::createFileManager() {
   assert(VFS && "CompilerInstance needs a VFS for creating FileManager");
   FileMgr = llvm::makeIntrusiveRefCnt<FileManager>(getFileSystemOpts(), VFS);
-  return FileMgr.get();
 }
 
 // Source Manager
 
-void CompilerInstance::createSourceManager(FileManager &FileMgr) {
-  SourceMgr =
-      llvm::makeIntrusiveRefCnt<SourceManager>(getDiagnostics(), FileMgr);
+void CompilerInstance::createSourceManager() {
+  assert(Diagnostics && "FileManager needed for creating SourceManager");
+  assert(FileMgr && "DiagnosticsEngine needed for creating SourceManager");
----------------
benlangmuir wrote:

The assert messages are backwards

https://github.com/llvm/llvm-project/pull/160748