[Lldb-commits] [lldb] [LLDB][PDB] Warn if DIA plugin is requested but not available (PR #160067)

[Michael Buch via lldb-commits]

================
@@ -136,6 +141,21 @@ class PluginProperties : public Properties {
 
   bool UseNativeReader() const {
 #if LLVM_ENABLE_DIA_SDK && defined(_WIN32)
+    return IsNativeReaderRequested();
+#else
+    if (!IsNativeReaderRequested()) {
+      static std::once_flag g_warning_shown;
+      Debugger::ReportWarning(
----------------
Michael137 wrote:

> DIA PDB reader was explicitly requested

This holds because `IsNativeReaderRequested` will only return `false` when a user specified `LLDB_USE_NATIVE_PDB_READER` to be any non-empty string other than `on`/`yes`/`1`/`true`, right?

https://github.com/llvm/llvm-project/pull/160067