[Lldb-commits] [lldb] bce48c8 - [lldb] Don't call FixDataAddress when reading fp in ReadGPRValue (#159606)

[via lldb-commits]

Author: Felipe de Azevedo Piovezan
Date: 2025-09-19T07:45:08-07:00
New Revision: bce48c89a04df5d5918d787e8b481cdfb0707307

URL: https://github.com/llvm/llvm-project/commit/bce48c89a04df5d5918d787e8b481cdfb0707307
DIFF: https://github.com/llvm/llvm-project/commit/bce48c89a04df5d5918d787e8b481cdfb0707307.diff

LOG: [lldb] Don't call FixDataAddress when reading fp in ReadGPRValue (#159606)

Based on testing on processors that use pointer metadata, and with all
the work done to delay calls to FixDataAddress, this is no longer
necessary.

Note that, with debugserver in particular, this is an NFC change: the
code path here is for frame zero, and debugserver will strip metadata
when reading fp from frame zero anyway.

Added: 
    

Modified: 
    lldb/source/Target/RegisterContextUnwind.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Target/RegisterContextUnwind.cpp b/lldb/source/Target/RegisterContextUnwind.cpp
index 7f6ead1e7ccab..c6d15fc6be0a6 100644
--- a/lldb/source/Target/RegisterContextUnwind.cpp
+++ b/lldb/source/Target/RegisterContextUnwind.cpp
@@ -2223,9 +2223,6 @@ bool RegisterContextUnwind::ReadGPRValue(lldb::RegisterKind register_kind,
         if (generic_regnum == LLDB_REGNUM_GENERIC_PC ||
             generic_regnum == LLDB_REGNUM_GENERIC_RA)
           value = abi_sp->FixCodeAddress(value);
-        if (generic_regnum == LLDB_REGNUM_GENERIC_SP ||
-            generic_regnum == LLDB_REGNUM_GENERIC_FP)
-          value = abi_sp->FixDataAddress(value);
       }
       return true;
     }