[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

[Corentin Jabot via lldb-commits]

================
@@ -2544,6 +2544,19 @@ Stmt *BlockExpr::getBody() {
 //===----------------------------------------------------------------------===//
 // Generic Expression Routines
 //===----------------------------------------------------------------------===//
+namespace {
+/// Helper to determine wether \c E is a CXXConstructExpr constructing
+/// a DecompositionDecl. Used to skip Clang-generated calls to std::get
+/// for structured bindings.
+bool IsDecompositionDeclRefExpr(const Expr *E) {
+  const Expr *Unrwapped = E->IgnoreUnlessSpelledInSource();
+  const DeclRefExpr *Ref = llvm::dyn_cast_or_null<DeclRefExpr>(Unrwapped);
----------------
cor3ntin wrote:

I don't think E can be null, so Unwrapped probably cannot be null either, it should just be `dyn_cast`

https://github.com/llvm/llvm-project/pull/122265