[Lldb-commits] [lldb] [lldb] Add a static_assert that g_core_definitions matches the Core enum (PR #159452)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett commented:

`ArchSpecValidator<ArchSpec::eCore_arm_generic>` starts instantiating a chain of `ArchSpecValidator<I + 1>` until it gets to `ArchSpecValidator<ArchSpec::eCore_wasm32>` which does not inherit from anything so it stops there.

`arm_generic` being the first core value and `wasm32` being the last. At least right now.

Could you use `kNum_Cores` so we don't have to remember to update this when new ones are added?

Also the `eCore_wasm32` one has ane mpty body, so does that mean it does not get checked?

And you say 2 cores were in the wrong order but only one is moved in the diff. Maybe the other is a downstream thing?

https://github.com/llvm/llvm-project/pull/159452