[Lldb-commits] [lldb] [lldb] Unwind through ARM Cortex-M exceptions automatically (PR #153922)

[Jonas Devlieghere via lldb-commits]

JDevlieghere wrote:

> The one significant choice that we haven't agreed on at this point is whether `Architecture::GetArchitectureUnwindPlan` should return an empty UnwindPlanSP to indicate no override, or if it should return the `std::shared_ptr<const UnwindPlan>` identical to its input if it indicates that no override has been done. I want `RegisterContetUnwind` to be able to detect if its chosen UnwindPlan has changed, so it's mainly a question of how that is most clearly indicated, I think.

It looks like David marked the conversation as resolved which suggests that he's happy with your explanation. FWIW, personally I tend to side with the approach that retains the most fidelity. Here I'd argue that it's easier/cleaner to recognize an empty `UnwindPlanSP` than to do a pointer comparison.

https://github.com/llvm/llvm-project/pull/153922