[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

[John Harrison via lldb-commits]

================
@@ -62,7 +97,11 @@ struct Variables {
   /// These are the variables evaluated from debug console REPL.
   llvm::DenseMap<int64_t, lldb::SBValue> m_referencedpermanent_variables;
 
-  int64_t m_next_temporary_var_ref{VARREF_FIRST_VAR_IDX};
+  /// Key = frame_id
+  /// Value = (locals, globals Registers) scopes
+  std::map<uint32_t,
----------------
ashgti wrote:

Internally we encode both the thread + stack into the DAP StackeFrame.id field using this: https://github.com/llvm/llvm-project/blob/a070dbb0266fa46b213e353bb2200825773f3f7e/lldb/tools/lldb-dap/LLDBUtils.h#L128C9-L128C23

https://github.com/llvm/llvm-project/pull/124232