[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

[Anthony Eid via lldb-commits]

================
@@ -62,7 +97,11 @@ struct Variables {
   /// These are the variables evaluated from debug console REPL.
   llvm::DenseMap<int64_t, lldb::SBValue> m_referencedpermanent_variables;
 
-  int64_t m_next_temporary_var_ref{VARREF_FIRST_VAR_IDX};
+  /// Key = frame_id
+  /// Value = (locals, globals Registers) scopes
+  std::map<uint32_t,
----------------
Anthony-Eid wrote:

I'm a bit confused by this because `frame_id` should be unique according to the protocol. Is frame id different here than its' respective dap type? 

https://microsoft.github.io/debug-adapter-protocol/specification#Types_StackFrame 

> interface StackFrame {
>  /**
>    An identifier for the stack frame. It must be unique across all threads.
>    This id can be used to retrieve the scopes of the frame with the `scopes`
>    request or to restart the execution of a stack frame.
>   */
> id: number;

https://github.com/llvm/llvm-project/pull/124232