[Lldb-commits] [lldb] 4c17749 - [lldb][yaml2macho-core] change the two API tests to skipUnlessDarwin
Jason Molenda via lldb-commits
lldb-commits at lists.llvm.org
Thu Sep 4 19:53:28 PDT 2025
Author: Jason Molenda
Date: 2025-09-04T19:53:16-07:00
New Revision: 4c17749b6d26093f33efd13f798d47b893252b15
URL: https://github.com/llvm/llvm-project/commit/4c17749b6d26093f33efd13f798d47b893252b15
DIFF: https://github.com/llvm/llvm-project/commit/4c17749b6d26093f33efd13f798d47b893252b15.diff
LOG: [lldb][yaml2macho-core] change the two API tests to skipUnlessDarwin
These two 32-bit macho corefile tests are still failing on the
lldb-remote-linux-win bot, I'd expect the @skipIfWindows decorator
to skip the tests there until I can debug this, but somehow because
it's a remote windows execution it's not working. Change these tests
back to skipUnlessDarwin until I can figure out whether it's
yaml2macho-core or lldb's 32-bit mach-o corefile reader support on
windows which is the problem.
Added:
Modified:
lldb/test/API/macosx/arm-corefile-regctx/TestArmMachoCorefileRegctx.py
lldb/test/API/macosx/riscv32-corefile/TestRV32MachOCorefile.py
Removed:
################################################################################
diff --git a/lldb/test/API/macosx/arm-corefile-regctx/TestArmMachoCorefileRegctx.py b/lldb/test/API/macosx/arm-corefile-regctx/TestArmMachoCorefileRegctx.py
index e11f569c4f281..acb6956ec478b 100644
--- a/lldb/test/API/macosx/arm-corefile-regctx/TestArmMachoCorefileRegctx.py
+++ b/lldb/test/API/macosx/arm-corefile-regctx/TestArmMachoCorefileRegctx.py
@@ -13,7 +13,7 @@
class TestArmMachoCorefileRegctx(TestBase):
NO_DEBUG_INFO_TESTCASE = True
- @skipIfWindows # CI fail on Windows, lr has value 0x0F000000?
+ @skipUnlessDarwin # CI fail on Windows, lr has value 0x0F000000?
def test_armv7_corefile(self):
### Create corefile
corefile = self.getBuildArtifact("core")
diff --git a/lldb/test/API/macosx/riscv32-corefile/TestRV32MachOCorefile.py b/lldb/test/API/macosx/riscv32-corefile/TestRV32MachOCorefile.py
index 0516cea481ac6..ed39a3ca9d7e4 100644
--- a/lldb/test/API/macosx/riscv32-corefile/TestRV32MachOCorefile.py
+++ b/lldb/test/API/macosx/riscv32-corefile/TestRV32MachOCorefile.py
@@ -13,7 +13,7 @@
class TestRV32MachOCorefile(TestBase):
NO_DEBUG_INFO_TESTCASE = True
- @skipIfWindows # windows CI failure, says only 1 thread in corefile
+ @skipunlessDarwin # windows CI failure, says only 1 thread in corefile
@no_debug_info_test
def test_riscv32_gpr_corefile_registers(self):
corefile = self.getBuildArtifact("core")
More information about the lldb-commits
mailing list