[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

[Aiden Grossman via lldb-commits]

================
@@ -13,3 +13,15 @@
 config.name = "lldb"
 config.test_source_root = os.path.dirname(__file__)
 config.test_exec_root = os.path.join(config.lldb_obj_root, "test")
+
+# We prefer the lit internal shell which provides a better user experience on
+# failures and is faster unless the user explicitly disables it with
+# LIT_USE_INTERNAL_SHELL=0 env var.
+
+use_lit_shell = True
+lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL")
+if lit_shell_env:
+    use_lit_shell = lit.util.pythonize_bool(lit_shell_env)
+
+if use_lit_shell:
+    os.environ["LIT_USE_INTERNAL_SHELL"] = "1"
----------------
boomanaiden154 wrote:

Looks like that's because all of the shell tests override it in `lldb/test/Shell/lit.cfg.py`. I think you want to make this modification there.

https://github.com/llvm/llvm-project/pull/156729