[Lldb-commits] [lldb] [LLDB] Complete constant array member types in class members (PR #156370)

[Michael Buch via lldb-commits]

Michael137 wrote:

> > It completes the element type.
> 
> As in, "if an array type is encountered, it's immediately completed"? Because in native PDB (with this PR too), it would be delayed.

I meant, "completing a ConstantArrayType" is the same as "completing the element type". This PR implements the former, whereas the DWARF plugin we opted for the latter.

> > Is there a place in the PDB plugin where we can do the same thing we do for DWARF?
> 
> Yes, in `PdbAstBuilder::createArrayType` a `CompleteType(element_type)` could be added, and the test would pass too:
> 
> https://github.com/llvm/llvm-project/blob/74b9484fd62d6be9bc49e154800ceef0d74ef24f/lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp#L1170-L1172
> 
> Would this be a better place?

Yea that seems like the right thing to do

https://github.com/llvm/llvm-project/pull/156370