[Lldb-commits] [lldb] [lldb-dap] Fix typescript issue in updated typescript code. (PR #156117)
via lldb-commits
lldb-commits at lists.llvm.org
Fri Aug 29 15:27:30 PDT 2025
https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/156117
After PR 155021 landed, some typescript 'promises' in async functions were not 'await'ed, which caused us some build failures. This fixes that by adding 'await' in the appropriate places.
>From c6af4d675fa75220ec11b857728fcaa1d0391e6b Mon Sep 17 00:00:00 2001
From: Caroline Tice <cmtice at google.com>
Date: Fri, 29 Aug 2025 15:21:53 -0700
Subject: [PATCH] [lldb-dap] Fix typescript issue in updated typescript code.
After PR 155021 landed, some typescript 'promises' in async functions
were not 'await'ed, which caused us some build failures. This fixes
that by adding 'await' in the appropriate places.
---
lldb/tools/lldb-dap/src-ts/ui/symbols-provider.ts | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lldb/tools/lldb-dap/src-ts/ui/symbols-provider.ts b/lldb/tools/lldb-dap/src-ts/ui/symbols-provider.ts
index 84b9387ffe49f..951a5971e0bca 100644
--- a/lldb/tools/lldb-dap/src-ts/ui/symbols-provider.ts
+++ b/lldb/tools/lldb-dap/src-ts/ui/symbols-provider.ts
@@ -61,18 +61,18 @@ export class SymbolsProvider extends DisposableContext {
return;
}
- this.showSymbolsForModule(session, selectedModule.module);
+ await this.showSymbolsForModule(session, selectedModule.module);
}
private async showSymbolsForModule(session: vscode.DebugSession, module: DebugProtocol.Module) {
try {
const symbols = await this.getSymbolsForModule(session, module.id.toString());
- this.showSymbolsInNewTab(module.name.toString(), symbols);
+ await this.showSymbolsInNewTab(module.name.toString(), symbols);
} catch (error) {
if (error instanceof Error) {
- vscode.window.showErrorMessage("Failed to retrieve symbols: " + error.message);
+ await vscode.window.showErrorMessage("Failed to retrieve symbols: " + error.message);
} else {
- vscode.window.showErrorMessage("Failed to retrieve symbols due to an unknown error.");
+ await vscode.window.showErrorMessage("Failed to retrieve symbols due to an unknown error.");
}
return;
@@ -106,7 +106,7 @@ export class SymbolsProvider extends DisposableContext {
const symbolsTableScriptPath = panel.webview.asWebviewUri(vscode.Uri.joinPath(this.getExtensionResourcePath(), "symbols-table-view.js"));
panel.webview.html = getSymbolsTableHTMLContent(tabulatorJsPath, tabulatorCssPath, symbolsTableScriptPath);
- panel.webview.postMessage({ command: "updateSymbols", symbols: symbols });
+ await panel.webview.postMessage({ command: "updateSymbols", symbols: symbols });
}
private getExtensionResourcePath(): vscode.Uri {
More information about the lldb-commits
mailing list