[Lldb-commits] [lldb] DRAFT: Add a `breakpoint add` command to fix the option-madness that is `breakpoint set` (PR #156067)

via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 29 10:32:01 PDT 2025


jimingham wrote:

IIRC there's some formal way to mark PR's as draft's, but I didn't see where it was in the UI.

Anyway, I think that the code here is what I want, but the testing strategy needs to be fleshed out.  So far I haven't add any new capabilities to the `break add` commands that aren't in `break set`.  I tested it by adding the ability to switch the `lldbutils.run_break_set_...` routines, in the draft I hard coded it to use add.  That actually does a pretty good job of exercising the new code, because that's how we wrote most of the `break set` tests in the API tests.

But we don't want to not test `break set` and I don't think we want this to make two test variants.  So we still need to refine the testing strategy for this patch.

https://github.com/llvm/llvm-project/pull/156067


More information about the lldb-commits mailing list