[Lldb-commits] [lldb] [lldb] Restrict TestVariableAnnotationsDisassembler.py to ELF x86_64 (skip on Windows/COFF) (PR #156026)

via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 29 06:55:22 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r origin/main...HEAD lldb/test/API/functionalities/disassembler-variables/TestVariableAnnotationsDisassembler.py
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- TestVariableAnnotationsDisassembler.py	2025-08-29 13:48:05.000000 +0000
+++ TestVariableAnnotationsDisassembler.py	2025-08-29 13:54:58.923634 +0000
@@ -21,11 +21,11 @@
     def _disassemble_verbose_symbol(self, symname):
         self.runCmd(f"disassemble -n {symname} -v", check=True)
         return self.res.GetOutput()
 
     @skipIfWindows
-    @skipUnlessPlatform(["linux","freebsd","netbsd"])
+    @skipUnlessPlatform(["linux", "freebsd", "netbsd"])
     @skipIf(archs=no_match(["x86_64"]))
     def test_d_original_example_O1(self):
         obj = self._build_obj("d_original_example.o")
         target = self._create_target(obj)
         out = self._disassemble_verbose_symbol("main")
@@ -35,11 +35,11 @@
         self.assertIn("i = ", out)
         self.assertNotIn("<decoding error>", out)
 
     @no_debug_info_test
     @skipIfWindows
-    @skipUnlessPlatform(["linux","freebsd","netbsd"])
+    @skipUnlessPlatform(["linux", "freebsd", "netbsd"])
     @skipIf(archs=no_match(["x86_64"]))
     def test_regs_int_params(self):
         obj = self._build_obj("regs_int_params.o")
         target = self._create_target(obj)
         out = self._disassemble_verbose_symbol("regs_int_params")
@@ -52,11 +52,11 @@
         self.assertRegex(out, r"\bf\s*=\s*(DW_OP_reg9\b|R9\b)")
         self.assertNotIn("<decoding error>", out)
 
     @no_debug_info_test
     @skipIfWindows
-    @skipUnlessPlatform(["linux","freebsd","netbsd"])
+    @skipUnlessPlatform(["linux", "freebsd", "netbsd"])
     @skipIf(archs=no_match(["x86_64"]))
     def test_regs_fp_params(self):
         obj = self._build_obj("regs_fp_params.o")
         target = self._create_target(obj)
         out = self._disassemble_verbose_symbol("regs_fp_params")
@@ -69,11 +69,11 @@
         self.assertRegex(out, r"\bf\s*=\s*(DW_OP_reg22\b|XMM5\b)")
         self.assertNotIn("<decoding error>", out)
 
     @no_debug_info_test
     @skipIfWindows
-    @skipUnlessPlatform(["linux","freebsd","netbsd"])
+    @skipUnlessPlatform(["linux", "freebsd", "netbsd"])
     @skipIf(archs=no_match(["x86_64"]))
     def test_regs_mixed_params(self):
         obj = self._build_obj("regs_mixed_params.o")
         target = self._create_target(obj)
         out = self._disassemble_verbose_symbol("regs_mixed_params")
@@ -86,11 +86,11 @@
         self.assertRegex(out, r"\bz\s*=\s*(DW_OP_reg19\b|XMM2\b|DW_OP_reg\d+\b)")
         self.assertNotIn("<decoding error>", out)
 
     @no_debug_info_test
     @skipIfWindows
-    @skipUnlessPlatform(["linux","freebsd","netbsd"])
+    @skipUnlessPlatform(["linux", "freebsd", "netbsd"])
     @skipIf(archs=no_match(["x86_64"]))
     def test_live_across_call(self):
         obj = self._build_obj("live_across_call.o")
         target = self._create_target(obj)
         out = self._disassemble_verbose_symbol("live_across_call")
@@ -100,11 +100,11 @@
         self.assertRegex(out, r"\br\s*=\s*(DW_OP_reg0\b|RAX\b|DW_OP_reg\d+\b)")
         self.assertNotIn("<decoding error>", out)
 
     @no_debug_info_test
     @skipIfWindows
-    @skipUnlessPlatform(["linux","freebsd","netbsd"])
+    @skipUnlessPlatform(["linux", "freebsd", "netbsd"])
     @skipIf(archs=no_match(["x86_64"]))
     def test_loop_reg_rotate(self):
         obj = self._build_obj("loop_reg_rotate.o")
         target = self._create_target(obj)
         out = self._disassemble_verbose_symbol("loop_reg_rotate")
@@ -116,11 +116,11 @@
         self.assertRegex(out, r"\bi\s*=\s*(DW_OP_reg\d+\b|R[A-Z0-9]+)")
         self.assertNotIn("<decoding error>", out)
 
     @no_debug_info_test
     @skipIfWindows
-    @skipUnlessPlatform(["linux","freebsd","netbsd"])
+    @skipUnlessPlatform(["linux", "freebsd", "netbsd"])
     @skipIf(archs=no_match(["x86_64"]))
     def test_seed_reg_const_undef(self):
         obj = self._build_obj("seed_reg_const_undef.o")
         target = self._create_target(obj)
         out = self._disassemble_verbose_symbol("main")

``````````

</details>


https://github.com/llvm/llvm-project/pull/156026


More information about the lldb-commits mailing list