[Lldb-commits] [lldb] [lldb] Skip TestVariableAnnotationsDisassembler.py on non-x86 architectures (PR #155942)

[Abdullah Mohammad Amin via lldb-commits]

https://github.com/UltimateForce21 updated https://github.com/llvm/llvm-project/pull/155942

>From ff98d641380d7e4bda4805b8545586310d219826 Mon Sep 17 00:00:00 2001
From: Abdullah Amin <abdullahmohammad155 at gmail.com>
Date: Fri, 29 Aug 2025 05:53:13 -0400
Subject: [PATCH] [lldb] Skip TestVariableAnnotationsDisassembler.py on non-x86
 architectures

The test TestVariableAnnotationsDisassembler.py relies on an .s input file generated for x86_64 with assembly directives that are not portable (e.g., DWARF sections and comments using #).
This causes build failures on non-x86 targets such as AArch64.

This change skips the test unless the architecture is x86_64, ensuring it only runs where the assembly input is valid.
---
 .../TestVariableAnnotationsDisassembler.py                 | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/lldb/test/API/functionalities/disassembler-variables/TestVariableAnnotationsDisassembler.py b/lldb/test/API/functionalities/disassembler-variables/TestVariableAnnotationsDisassembler.py
index e6f26bf8fd389..4d99ea771605a 100644
--- a/lldb/test/API/functionalities/disassembler-variables/TestVariableAnnotationsDisassembler.py
+++ b/lldb/test/API/functionalities/disassembler-variables/TestVariableAnnotationsDisassembler.py
@@ -22,6 +22,7 @@ def _disassemble_verbose_symbol(self, symname):
         self.runCmd(f"disassemble -n {symname} -v", check=True)
         return self.res.GetOutput()
 
+    @skipIf(archs=no_match(["x86_64"]))
     def test_d_original_example_O1(self):
         obj = self._build_obj("d_original_example.o")
         target = self._create_target(obj)
@@ -33,6 +34,7 @@ def test_d_original_example_O1(self):
         self.assertNotIn("<decoding error>", out)
 
     @no_debug_info_test
+    @skipIf(archs=no_match(["x86_64"]))
     def test_regs_int_params(self):
         obj = self._build_obj("regs_int_params.o")
         target = self._create_target(obj)
@@ -47,6 +49,7 @@ def test_regs_int_params(self):
         self.assertNotIn("<decoding error>", out)
 
     @no_debug_info_test
+    @skipIf(archs=no_match(["x86_64"]))
     def test_regs_fp_params(self):
         obj = self._build_obj("regs_fp_params.o")
         target = self._create_target(obj)
@@ -61,6 +64,7 @@ def test_regs_fp_params(self):
         self.assertNotIn("<decoding error>", out)
 
     @no_debug_info_test
+    @skipIf(archs=no_match(["x86_64"]))
     def test_regs_mixed_params(self):
         obj = self._build_obj("regs_mixed_params.o")
         target = self._create_target(obj)
@@ -75,6 +79,7 @@ def test_regs_mixed_params(self):
         self.assertNotIn("<decoding error>", out)
 
     @no_debug_info_test
+    @skipIf(archs=no_match(["x86_64"]))
     def test_live_across_call(self):
         obj = self._build_obj("live_across_call.o")
         target = self._create_target(obj)
@@ -86,6 +91,7 @@ def test_live_across_call(self):
         self.assertNotIn("<decoding error>", out)
 
     @no_debug_info_test
+    @skipIf(archs=no_match(["x86_64"]))
     def test_loop_reg_rotate(self):
         obj = self._build_obj("loop_reg_rotate.o")
         target = self._create_target(obj)
@@ -99,6 +105,7 @@ def test_loop_reg_rotate(self):
         self.assertNotIn("<decoding error>", out)
 
     @no_debug_info_test
+    @skipIf(archs=no_match(["x86_64"]))
     def test_seed_reg_const_undef(self):
         obj = self._build_obj("seed_reg_const_undef.o")
         target = self._create_target(obj)