[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

[Greg Clayton via lldb-commits]

================
@@ -488,22 +488,26 @@ class SymbolFile : public PluginInterface {
     return false;
   };
 
-  /// Get number of loaded/parsed DWO files. This is emitted in "statistics
-  /// dump"
+  /// Retrieves statistics about DWO files associated with this symbol file.
+  /// This function returns a DWOStats struct containing:
+  ///   - The number of successfully loaded/parsed DWO files.
+  ///   - The total number of DWO files encountered.
+  ///   - The number of DWO CUs that failed to load due to errors.
+  /// If this symbol file does not support DWO files, all counts will be zero.
   ///
   /// \returns
-  ///     A pair containing (loaded_dwo_count, total_dwo_count). If this
-  ///     symbol file doesn't support DWO files, both counts will be 0.
-  virtual std::pair<uint32_t, uint32_t> GetDwoFileCounts() { return {0, 0}; }
-
-  virtual lldb::TypeSP
-  MakeType(lldb::user_id_t uid, ConstString name,
-           std::optional<uint64_t> byte_size, SymbolContextScope *context,
-           lldb::user_id_t encoding_uid,
-           Type::EncodingDataType encoding_uid_type, const Declaration &decl,
-           const CompilerType &compiler_qual_type,
-           Type::ResolveState compiler_type_resolve_state,
-           uint32_t opaque_payload = 0) = 0;
----------------
clayborg wrote:

I would be a good idea to turn off auto clang-format for this file and revert the changed lines that aren't a part of this commit. All of the changes to `MakeType` below should be reverted. The only way to do this is to turn off the auto clang format feature.

https://github.com/llvm/llvm-project/pull/155023