[Lldb-commits] [lldb] [lldb] Fix use after free on ModuleList::RemoveSharedModuleIfOrphaned (PR #155331)

[Augusto Noronha via lldb-commits]

augusto2112 wrote:

@JDevlieghere @felipepiovezan any suggestions on this, or can I merge it as is? 

The other way to do this would be to allow already freed pointers, document it, and be careful to never dereference it. That feels weird and wasteful though.

I guess a third possibility is add a new function which takes a reference to the shared pointer (haha), have _it_ check the count, free the pointer from shared pointer and remove the orphans if the reference count > 1.

https://github.com/llvm/llvm-project/pull/155331