[Lldb-commits] [lldb] [lldb][ARM] Port Arm Linux to use NativeRegisterContextDBReg (PR #152284)

[David Spickett via lldb-commits]

================
@@ -76,17 +77,26 @@ class NativeRegisterContextDBReg
 
   // On AArch64 and Loongarch the hardware breakpoint length size is 4, and the
   // target address must 4-byte alignment.
-  bool ValidateBreakpoint(size_t size, lldb::addr_t addr) {
+  virtual bool ValidateBreakpoint(size_t size, lldb::addr_t addr) {
     return (size == 4) && !(addr & 0x3);
   }
+
   struct WatchpointDetails {
     size_t size;
     lldb::addr_t addr;
   };
   virtual std::optional<WatchpointDetails>
   AdjustWatchpoint(const WatchpointDetails &details) = 0;
+
+  using BreakpointDetails = WatchpointDetails;
+  virtual std::optional<BreakpointDetails>
+  AdjustBreakpoint(const BreakpointDetails &details) {
----------------
DavidSpickett wrote:

It wasn't and I think the reason I didn't notice is that the LLDB client always aligns the addresses. I suspect it was there for a time where we didn't, or some other client didn't. So I'm leaving it in. There's now a call to it in the generic DBReg code.

https://github.com/llvm/llvm-project/pull/152284