[Lldb-commits] [lldb] [lldb] Add utility to create Mach-O corefile from YAML desc (PR #153911)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- lldb/tools/yaml2macho-core/CoreSpec.cpp lldb/tools/yaml2macho-core/CoreSpec.h lldb/tools/yaml2macho-core/LCNoteWriter.cpp lldb/tools/yaml2macho-core/LCNoteWriter.h lldb/tools/yaml2macho-core/MemoryWriter.cpp lldb/tools/yaml2macho-core/MemoryWriter.h lldb/tools/yaml2macho-core/ThreadWriter.cpp lldb/tools/yaml2macho-core/ThreadWriter.h lldb/tools/yaml2macho-core/Utility.cpp lldb/tools/yaml2macho-core/Utility.h lldb/tools/yaml2macho-core/yaml2macho.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/tools/yaml2macho-core/LCNoteWriter.cpp b/lldb/tools/yaml2macho-core/LCNoteWriter.cpp
index 142ad2eb2..dca65be15 100644
--- a/lldb/tools/yaml2macho-core/LCNoteWriter.cpp
+++ b/lldb/tools/yaml2macho-core/LCNoteWriter.cpp
@@ -28,9 +28,9 @@ void create_lc_note_binary_load_cmd(const CoreSpec &spec,
   uuid.SetFromStringRef(uuid_str);
   for (size_t i = 0; i < uuid.GetBytes().size(); i++)
     payload_bytes.push_back(uuid.GetBytes().data()[i]);
-  add_uint64(payload_bytes, UINT64_MAX);       // address
-  add_uint64(payload_bytes, slide);            // slide
-  payload_bytes.push_back(0);                  // name_cstring
+  add_uint64(payload_bytes, UINT64_MAX); // address
+  add_uint64(payload_bytes, slide);      // slide
+  payload_bytes.push_back(0);            // name_cstring
 
   size_t payload_size = payload_bytes.size() - starting_payload_size;
   // Pad out the entry to a 4-byte aligned size.
diff --git a/lldb/tools/yaml2macho-core/ThreadWriter.cpp b/lldb/tools/yaml2macho-core/ThreadWriter.cpp
index d15564626..093d973ba 100644
--- a/lldb/tools/yaml2macho-core/ThreadWriter.cpp
+++ b/lldb/tools/yaml2macho-core/ThreadWriter.cpp
@@ -75,7 +75,7 @@ void add_lc_threads_armv7(CoreSpec &spec,
           add_reg_value(spec, lc, rs.registers, names[i], 4);
       }
       if (rs.flavor == RegisterFlavor::EXC) {
-        add_uint32(lc, ARM_EXCEPTION_STATE); // thread_command.flavor
+        add_uint32(lc, ARM_EXCEPTION_STATE);       // thread_command.flavor
         add_uint32(lc, ARM_EXCEPTION_STATE_COUNT); // thread_command.count
         const char *names[] = {"far", "esr", "exception", nullptr};
         for (int i = 0; names[i]; i++)

``````````

</details>


https://github.com/llvm/llvm-project/pull/153911