[Lldb-commits] [clang] [lldb] [UBSan][BoundsSafety] Implement support for more expressive "trap reasons" (PR #154618)

[Paul Kirth via lldb-commits]

================
@@ -0,0 +1,21 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+///
+/// \file
+/// This file contains the necessary includes for using
+/// `RuntimeTrapDiagnosticBuilder`.
----------------
ilovepi wrote:

I kind of though a file level comment would describe what the trap diagnostic was and any other details that would be relevant for users. Basically something similar to what is in `DiagnosticTrapKinds.td`

Looking at similar files though, it seems we don't typically do that. It's my mistake for not looking at the local convention in similar headers, so I'm fine with dropping it.

https://github.com/llvm/llvm-project/pull/154618